-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kernel_info request on the control channel #82
Conversation
From the description of this proposal, it seems like the problem at hand can be solved at the Jupyter Server level, without introducing backwards incompatible protocol changes. Can jupyter server be changed to issue its initial It makes sense to encourage clients to issue |
@ivanov I agree that a backward incompatible change is not ideal. We could do what we did with |
@JohanMabille I'm still not sure that we want to necessarily deprecate the message pair on the shell channel. I understand that it's easier for implementors if a given message should only appear on one channel. However, one of the affordances with the shell channel approach is the current pattern of clients issuing a Specific example would be similar to the debugging example in the JEP but suppose that instead of debugging, you have a long running computation (like One possibility could be to add a kernel status message to the body of a |
On the core of this proposal, we clearly need to require kernel info to be supported on the control channel, for situations such as connecting to a kernel that is currently blocked on a breakpoint or currently executing a long-running cell. In my opinion, this should be resolved at the protocol level because it also applies to cases where there isn't a server (connecting to an existing kernel). On the other point brought up by @ivanov on the semantics of kernel idle and busy messages: We would like to make some proposals at a later stage on this subject. My take on this is that idle and busy messages should eventually only concern the state of the Shell channel (it is not of interest to kernel end-users to know whether the control channel is processing messages. Control channel messages ought to be processed fast in a non-blocking way as much as possible). |
Updating comments on this, I agree with requiring support for kernel_info on control, and agree with not deprecating it at all on shell. That doesn't appear to have a material benefit, and does have a breaking cost. |
3ea6434
to
fb5446a
Compare
I rewrote the proposal to state that the |
Co-authored-by: gabalafou <[email protected]>
Co-authored-by: gabalafou <[email protected]>
I'm in favor of this PR. This is already implemented in Jupyter Server (and Jupyverse). I proposed some minor changes to the JEP description to include a few extra details that might useful for future reference. |
Co-authored-by: Zachary Sailer <[email protected]>
Co-authored-by: Zachary Sailer <[email protected]>
7 yes, 1 abstention, and 2 non votes, let's merge! |
In this JEP we propose the
kernel_info
request can be sent on both the shell and the control channels, to fix issues like this and this.cc @SylvainCorlay and @minrk who I have talked to about this JEP.
Voting from @jupyter/software-steering-council